ci: lock package versions

.gitea/workflows/checks-test.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           python-version: "3.13"
       - name: Intall test dependencies
-        run: pip3 install yamllint==1.37.1 ansible-lint==25.12.0
+        run: pip3 install yamllint=1.37.1 ansible-lint==25.12.0
       - name: Lint code with yamllint
         run: "yamllint ."
       - name: Lint code with yamllint

molecule/default/converge.yml

@@ -8,7 +8,7 @@
       package:
         update_cache: true
         cache_valid_time: 600
-      when: ansible_facts["os_family"] == 'Debian'
+      when: ansible_os_family == 'Debian'
 
     - name: Ensure build dependencies are installed (RedHat).
       package:
@@ -16,13 +16,13 @@
           - openssh-server
           - openssh-clients
         state: present
-      when: ansible_facts["os_family"]  == 'RedHat'
+      when: ansible_os_family == 'RedHat'
 
     - name: Ensure build dependencies are installed (Fedora).
       package:
         name: procps
         state: present
-      when: ansible_facts["distribution"]  == 'Fedora'
+      when: ansible_distribution == 'Fedora'
 
     - name: Ensure build dependencies are installed (Debian).
       package:
@@ -30,7 +30,7 @@
           - openssh-server
           - openssh-client
         state: present
-      when: ansible_facts["os_family"] == 'Debian'
+      when: ansible_os_family == 'Debian'
 
     - name: Ensure auth.log file is present.
       copy:
@@ -38,7 +38,7 @@
         content: ""
         force: false
         mode: 0644
-      when: ansible_facts["distribution"] == 'Debian'
+      when: ansible_distribution == 'Debian'
 
   roles:
     - role: palkx.users

tasks/main.yml

@@ -7,7 +7,7 @@
 
 - name: Create users
   ansible.builtin.include_tasks: user.yml
-  when: ansible_default_ipv4.address in users[username]['passwords'] or users[username]['passwords'].get('default', '') != ''
+  when: ansible_default_ipv4.address in users[username]['passwords'] or users[username]['passwords'].get('default', None) is not None
   with_items: "{{ users.keys() }}"
   loop_control:
     loop_var: username

tasks/user.yml

@@ -11,15 +11,15 @@
   ansible.builtin.user:
     name: "{{ username }}"
     password: "{{ users[username]['passwords'].get(ansible_default_ipv4.address) }}"
-  when: "ansible_facts['default_ipv4'].address in users[username]['passwords'] and
-        users[username]['passwords'].get(ansible_facts['default_ipv4'].address) != 'default'"
+  when: "ansible_default_ipv4.address in users[username]['passwords'] and
+        users[username]['passwords'].get(ansible_default_ipv4.address) != 'default'"
 
 - name: "Set default password for user `{{ username }}`"
   ansible.builtin.user:
     name: "{{ username }}"
     password: "{{ users[username]['passwords'].get('default') }}"
-  when: "ansible_facts['default_ipv4'].address not in users[username]['passwords'] or
-        users[username]['passwords'].get(ansible_facts['default_ipv4'].address) == 'default'"
+  when: "ansible_default_ipv4.address not in users[username]['passwords'] or
+        users[username]['passwords'].get(ansible_default_ipv4.address) == 'default'"
 
 - name: "Setup ssh key for user `{{ username }}`"
   ansible.posix.authorized_key: